Update FluentUI Blazor Components to 4.4#2140
Closed
tlmii wants to merge 1 commit intodotnet:mainfrom
Closed
Conversation
ghost
added
the
area-integrations
kvenkatrajan
approved these changes
Feb 8, 2024
JamesNK
requested changes
Feb 9, 2024
Member
JamesNK
left a comment
JamesNK
left a comment
There was a problem hiding this comment.
I tested and found a bad memory leak related to overflow control.
Created an issue in their repo:
microsoft/fluentui-blazor#1483
dotnet-policy-service
bot
added
the
needs-author-action
Member
Author
|
Obsolete by #2301 |
dotnet-policy-service
bot
removed
the
needs-author-action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2064
I did a pass through all the pages to make sure things rendered correctly and they did seem to. @JamesNK I couldn't repro the issue with the filter overflow on metrics to see if it was fixed - the box seems always wide enough to list all of them (though maybe I missed a metric somewhere with more filters).
Microsoft Reviewers: Open in CodeFlow